Skip to content

Enable isolates storage tests on maccatalyst #90150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Enable isolates storage tests on maccatalyst #90150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e5adc3
Enable isolates storage tests on maccatalyst
mkhamoyan Aug 8, 2023
025bf81
Merge branch 'main' into isolated_storage_tests
mkhamoyan Aug 9, 2023
2c9eb92
Merge branch 'main' into isolated_storage_tests
mkhamoyan Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...es/System.IO.IsolatedStorage/tests/System/IO/IsolatedStorage/ContainsUnknownFilesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ private static MethodInfo s_containsUnknownFilesMethod
= typeof(IsolatedStorageFile).GetMethod("ContainsUnknownFiles", BindingFlags.NonPublic | BindingFlags.Instance);

[Theory, MemberData(nameof(ValidStores))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/87485", TestPlatforms.MacCatalyst)]
public void ContainsUnknownFiles_CleanStore(PresetScopes scope)
{
TestHelper.WipeStores();
Expand All @@ -24,7 +23,6 @@ public void ContainsUnknownFiles_CleanStore(PresetScopes scope)
}

[Theory, MemberData(nameof(ValidStores))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/87485", TestPlatforms.MacCatalyst)]
public void ContainsUnknownFiles_OkFiles(PresetScopes scope)
{
TestHelper.WipeStores();
Expand All @@ -44,7 +42,6 @@ public void ContainsUnknownFiles_OkFiles(PresetScopes scope)
}

[Theory, MemberData(nameof(ValidStores))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/87485", TestPlatforms.MacCatalyst)]
public void ContainsUnknownFiles_NotOkFiles(PresetScopes scope)
{
TestHelper.WipeStores();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.IsolatedStorage/tests/System/IO/IsolatedStorage/CopyFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ public void CopyFile_CopyOver(PresetScopes scope)
}

[Theory, MemberData(nameof(ValidStores))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/87485", TestPlatforms.MacCatalyst)]
public void CopyFile_CopiesFile(PresetScopes scope)
{
TestHelper.WipeStores();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.IsolatedStorage/tests/System/IO/IsolatedStorage/MoveFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ public void MoveFile_MoveOver(PresetScopes scope)
}

[Theory, MemberData(nameof(ValidStores))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/87485", TestPlatforms.MacCatalyst)]
public void MoveFile_MovesFile(PresetScopes scope)
{
TestHelper.WipeStores();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.IsolatedStorage/tests/System/IO/IsolatedStorage/OpenFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ public void OpenFile_PassesFileMode()
}

[Theory, MemberData(nameof(ValidStores))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/87485", TestPlatforms.MacCatalyst)]
public void OpenFile_Existence(PresetScopes scope)
{
TestHelper.WipeStores();
Expand Down