- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.2k
 
          Avoid string allocation and improve performance of JsonProperty.WriteTo
          #90074
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 5 commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      ad30f54
              
                Avoid string allocation in WriteTo when possible.
              
              
                karakasa 41f5c37
              
                Avoid alloc in unescaping & escaping.
              
              
                karakasa d4d84b1
              
                Fix bugs on escaped property names
              
              
                karakasa c368aa3
              
                Change IndexOf to Contains if possible.
              
              
                karakasa c5c5593
              
                Further avoid alloc by inlining GetUnescapedSpan
              
              
                karakasa 1528bf3
              
                Move writing logic to JsonElement;
              
              
                karakasa 5690487
              
                Move logic into JsonDocument
              
              
                karakasa b6c8606
              
                fix format
              
              
                karakasa 9644915
              
                fix format 2
              
              
                karakasa 63da811
              
                improve comment
              
              
                karakasa df8e6fa
              
                removed unused stub
              
              
                karakasa d2fd37c
              
                added assertion
              
              
                karakasa ecca233
              
                removed unnecessary test
              
              
                karakasa File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.