Skip to content

fix Accept assert #89901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix Accept assert #89901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,23 @@ public partial class SocketAsyncEventArgs : EventArgs, IDisposable

private void AcceptCompletionCallback(IntPtr acceptedFileDescriptor, Memory<byte> socketAddress, SocketError socketError)
{
CompleteAcceptOperation(acceptedFileDescriptor, socketAddress);
CompleteAcceptOperation(acceptedFileDescriptor, socketAddress, socketError);

CompletionCallback(0, SocketFlags.None, socketError);
}

private void CompleteAcceptOperation(IntPtr acceptedFileDescriptor, Memory<byte> socketAddress)
private void CompleteAcceptOperation(IntPtr acceptedFileDescriptor, Memory<byte> socketAddress, SocketError socketError)
{
_acceptedFileDescriptor = acceptedFileDescriptor;
Debug.Assert(socketAddress.Length > 0);
_acceptAddressBufferCount = socketAddress.Length;
if (socketError == SocketError.Success)
{
Debug.Assert(socketAddress.Length > 0);
_acceptAddressBufferCount = socketAddress.Length;
}
else
{
_acceptAddressBufferCount = 0;
}
}

internal unsafe SocketError DoOperationAccept(Socket _ /*socket*/, SafeSocketHandle handle, SafeSocketHandle? acceptHandle, CancellationToken cancellationToken)
Expand All @@ -53,7 +60,7 @@ internal unsafe SocketError DoOperationAccept(Socket _ /*socket*/, SafeSocketHan

if (socketError != SocketError.IOPending)
{
CompleteAcceptOperation(acceptedFd, new Memory<byte>(_acceptBuffer, 0, socketAddressLen));
CompleteAcceptOperation(acceptedFd, new Memory<byte>(_acceptBuffer, 0, socketAddressLen), socketError);
FinishOperationSync(socketError, 0, SocketFlags.None);
}

Expand Down