-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix EventLog test CanReadAndWriteMessages #89586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EventLog test CanReadAndWriteMessages #89586
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-eventlog Issue DetailsWe have many EventLog tests that are executed if the process is elevated but we never run them with RemoteExecutor. I am investigating if this could help them pass. I ran this in an elevated console and it failed with an error stating that it still had a null terminator, even though we removed it: It seems the problem is that the buffer may end up with multiple null terminators, so I removed them. The test now passes locally in an elevated console in Win11 arm64. Now I need to see the CI results.
|
Fixes #88224
I ran this in an elevated console and it failed with the reported error:
It seems the problem is that the buffer may end up with multiple null terminators, so I adjusted the code to make sure we remove them all.