Skip to content

[nativeaot][ios] Improve Native AOT test coverage on apple mobile platforms #89301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Aug 4, 2023
Merged

[nativeaot][ios] Improve Native AOT test coverage on apple mobile platforms #89301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f105619
Enable TestLinqExpressions test
kotlarmilos Jul 21, 2023
807cb2b
Test maccatalyst job on Native AOT
kotlarmilos Jul 21, 2023
8eac5df
Test other smoke runtime tests on Native AOT
kotlarmilos Jul 21, 2023
994d711
Add entry point support for Native AOT runtime tests
kotlarmilos Jul 21, 2023
c7c79df
Merge branch 'dotnet:main' into improvement/nativeaot-smoke-tests
kotlarmilos Jul 21, 2023
f821a3f
Add missing quotations
kotlarmilos Jul 21, 2023
5acefa4
Fix app name to match the wrappers
kotlarmilos Jul 21, 2023
d31ba82
Enable runtime tests with a single entry point
kotlarmilos Jul 22, 2023
d4af827
Exclude tests with multiple entry points
kotlarmilos Jul 22, 2023
5027fb7
Exclude tests with multiple entry points
kotlarmilos Jul 22, 2023
e8acddb
Exclude exceptions test
kotlarmilos Jul 22, 2023
9b11448
Disable tests using issues.targets item group and remove maccatalyst …
kotlarmilos Jul 25, 2023
fdd2fc7
Merge branch 'dotnet:main' into improvement/nativeaot-smoke-tests
kotlarmilos Jul 25, 2023
61111c0
Add tracking issue for disabled tests
kotlarmilos Jul 25, 2023
ffab6dc
Enable more tests
kotlarmilos Jul 26, 2023
1b14030
Disable tests with CLRTestTargetUnsupported
kotlarmilos Jul 26, 2023
4b0d5c5
Disable tests with multiple entry points
kotlarmilos Jul 27, 2023
a275bd5
Enable more tests
kotlarmilos Jul 28, 2023
4e391d2
Merge branch 'dotnet:main' into improvement/nativeaot-smoke-tests
kotlarmilos Jul 28, 2023
5204a23
Test maccayalyst with Native AOT
kotlarmilos Aug 1, 2023
12bdc28
Disable failing test
kotlarmilos Aug 1, 2023
5cdc570
Merge branch 'improvement/nativeaot-smoke-tests' of github.com:kotlar…
kotlarmilos Aug 1, 2023
68a9585
Merge branch 'dotnet:main' into improvement/nativeaot-smoke-tests
kotlarmilos Aug 1, 2023
ca6816c
Remove maccatalyst tests
kotlarmilos Aug 1, 2023
fb4a29a
Merge branch 'improvement/nativeaot-smoke-tests' of github.com:kotlar…
kotlarmilos Aug 1, 2023
e7d26db
Add tracking issue for disabled tests
kotlarmilos Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,5 @@ jobs:
extraStepsTemplate: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
extraStepsParameters:
creator: dotnet-bot
testBuildArgs: tree nativeaot/SmokeTests/UnitTests /p:BuildNativeAOTRuntimePack=true
testBuildArgs: tree nativeaot/SmokeTests /p:BuildNativeAOTRuntimePack=true
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)
2 changes: 1 addition & 1 deletion eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,5 @@ jobs:
extraStepsTemplate: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
extraStepsParameters:
creator: dotnet-bot
testBuildArgs: tree nativeaot/SmokeTests/UnitTests /p:BuildNativeAOTRuntimePack=true
testBuildArgs: tree nativeaot/SmokeTests /p:BuildNativeAOTRuntimePack=true
testRunNamePrefixSuffix: NativeAOT_$(_BuildConfig)
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/Exceptions/Exceptions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<CLRTestPriority>0</CLRTestPriority>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<ServerGarbageCollection>true</ServerGarbageCollection>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
</PropertyGroup>
<ItemGroup>
<Compile Include="Exceptions.cs" />
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/FrameworkStrings/Baseline.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
<OutputType>Exe</OutputType>
<CLRTestKind>BuildAndRun</CLRTestKind>
<CLRTestPriority>0</CLRTestPriority>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
</PropertyGroup>
<ItemGroup>
<Compile Include="Program.cs" />
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/FrameworkStrings/UseSystemResourceKeys.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

<!-- Requires the framework to also be compiled with UseSystemResourceKeys -->
<CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true'">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/HardwareIntrinsics/X64Avx.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' != 'x64'">true</CLRTestTargetUnsupported>
<!-- Sanitizers increase the binary size, so it ends up outside of our expected range. -->
<CLRTestTargetUnsupported Condition="'$(EnableNativeSanitizers)' != ''">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);AVX_INTRINSICS;VECTORT128_INTRINSICS</DefineConstants>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/HardwareIntrinsics/X64Avx2.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' != 'x64'">true</CLRTestTargetUnsupported>
<!-- Sanitizers increase the binary size, so it ends up outside of our expected range. -->
<CLRTestTargetUnsupported Condition="'$(EnableNativeSanitizers)' != ''">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);AVX2_INTRINSICS;VECTORT256_INTRINSICS</DefineConstants>
</PropertyGroup>
Expand Down
4 changes: 3 additions & 1 deletion src/tests/nativeaot/SmokeTests/HardwareIntrinsics/X64Avx512.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
<OutputType>Exe</OutputType>
<CLRTestKind>BuildAndRun</CLRTestKind>
<CLRTestPriority>0</CLRTestPriority>
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' != 'x64' OR '$(TargetsOSX)' == 'true'">true</CLRTestTargetUnsupported>
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' != 'x64' or '$(TargetsOSX)' == 'true'">true</CLRTestTargetUnsupported>
<!-- Sanitizers increase the binary size, so it ends up outside of our expected range. -->
<CLRTestTargetUnsupported Condition="'$(EnableNativeSanitizers)' != ''">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);AVX512_INTRINSICS;VECTORT256_INTRINSICS</DefineConstants>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/HardwareIntrinsics/X64Avx_NoAvx2.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' != 'x64'">true</CLRTestTargetUnsupported>
<!-- Sanitizers increase the binary size, so it ends up outside of our expected range. -->
<CLRTestTargetUnsupported Condition="'$(EnableNativeSanitizers)' != ''">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);AVX_INTRINSICS;VECTORT128_INTRINSICS</DefineConstants>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/HardwareIntrinsics/X64Baseline.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' != 'x64'">true</CLRTestTargetUnsupported>
<!-- Sanitizers increase the binary size, so it ends up outside of our expected range. -->
<CLRTestTargetUnsupported Condition="'$(EnableNativeSanitizers)' != ''">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);BASELINE_INTRINSICS;VECTORT128_INTRINSICS</DefineConstants>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/HardwareIntrinsics/X64Sse42.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' != 'x64'">true</CLRTestTargetUnsupported>
<!-- Sanitizers increase the binary size, so it ends up outside of our expected range. -->
<CLRTestTargetUnsupported Condition="'$(EnableNativeSanitizers)' != ''">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);SSE42_INTRINSICS;VECTORT128_INTRINSICS</DefineConstants>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/PInvoke/PInvoke.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

<!-- Look for MULTIMODULE_BUILD #define for the more specific incompatible parts -->
<CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true'">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
</PropertyGroup>
<ItemGroup>
<Compile Include="PInvoke.cs" />
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/Reflection/Reflection_FromUsage.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

<!-- Look for MULTIMODULE_BUILD #define for the more specific incompatible parts -->
<CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true'">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>

<IlcTrimMetadata>false</IlcTrimMetadata>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/SharedLibrary/SharedLibrary.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<CLRTestPriority>0</CLRTestPriority>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<NativeLib>Shared</NativeLib>
<!-- Unable to compile a project with the Library output type for apple mobile devices -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
</PropertyGroup>

<PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/tests/nativeaot/SmokeTests/StackTraceMetadata/StackTraceMetadata_Stripped.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<InvariantGlobalization>true</InvariantGlobalization>
<CLRTestTargetUnsupported Condition="'$(IlcMultiModule)' == 'true'">true</CLRTestTargetUnsupported>
<!-- Test infra issue on apple devices: https://github.com/dotnet/runtime/issues/89917 -->
<CLRTestTargetUnsupported Condition="'$(TargetsAppleMobile)' == 'true'">true</CLRTestTargetUnsupported>
<DefineConstants>$(DefineConstants);STRIPPED</DefineConstants>
<StackTraceSupport>false</StackTraceSupport>
</PropertyGroup>
Expand Down
7 changes: 1 addition & 6 deletions src/tests/nativeaot/SmokeTests/UnitTests/Delegates.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,7 @@ public static int Run()
result = Fail;
}

// ActiveIssue https://github.com/dotnet/runtime/issues/87924
if (!OperatingSystem.IsIOS() && !OperatingSystem.IsTvOS() && !OperatingSystem.IsMacCatalyst())
{
TestLinqExpressions.Run();
}

TestLinqExpressions.Run();
TestDefaultInterfaceMethods.Run();

return result;
Expand Down