Skip to content

fix wbt windows #88755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix wbt windows #88755

wants to merge 2 commits into from

Conversation

@radical
Copy link
Member

@radical radical commented Jul 12, 2023

  • [wasm] WBT: Fix breaking tests
  • [wasm] WBT: Set DOTNET_ROOT for tests

radical added 2 commits July 12, 2023 13:07
@radical
[wasm] WBT: Fix breaking tests
2e873dd 
`Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations`
broke with the latest sdk:

`/root/helix/work/workitem/e/dotnet-latest/sdk/8.0.100-preview.7.23362.1/Roslyn/Microsoft.CSharp.Core.targets(80,5): error MSB6004: The specified task executable location "/root/helix/work/workitem/e/dotnet-latest/dotnet/dotnet" is invalid.`

This was because dotnet/roslyn#68918 changed
to expect `DOTNET_ROOT` to be a directory instead of the exe path.
@radical
[wasm] WBT: Set DOTNET_ROOT for tests
c95f3c8
@radical radical added the arch-wasm WebAssembly architecture label Jul 12, 2023
@ghost ghost assigned radical Jul 12, 2023
@ghost ghost added the area-Build-mono label Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] WBT: Fix breaking tests
  • [wasm] WBT: Set DOTNET_ROOT for tests
Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical mentioned this pull request Jul 12, 2023
Merged
@radical radical closed this Jul 12, 2023
@radical radical deleted the fix-wbt-windows branch July 12, 2023 20:28
@build-analysis build-analysis bot mentioned this pull request Jul 12, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@maraf maraf Awaiting requested review from maraf maraf will be requested when the pull request is marked ready for review maraf is a code owner

@ilonatommy ilonatommy Awaiting requested review from ilonatommy ilonatommy will be requested when the pull request is marked ready for review ilonatommy is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical @lewing