Fix libraries Windows test runner script #88354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having HAS_TEST_RESULTS unset leads to a Windows CMD script syntax error. Clean up a few other things while there: 1. Explicitly set ENABLEEXTENSIONS 2. Set a variable to the test exit code. There's an unsafe assumption currently that `%ERRORLEVEL%` doesn't change between the test run and all of the subsequent uses. 3. Remove unnecessary quotes around setting `HAS_TEST_RESULTS=1` Fixes dotnet#88353
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsHaving HAS_TEST_RESULTS unset leads to a Windows CMD script syntax error. Clean up a few other things while there:
Fixes #88353
|
Contributor
Author
|
/azp run runtime-coreclr libraries-jitstress-random |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 3, 2023
Member
|
Can't use build analysis for this one - it seems to be having issues catching that there was a test retry. |
hoyosjs
approved these changes
Jul 4, 2023
Contributor
Author
|
libraries-jitstress-random shows the correct behavior for the test that previous had the failure fixed here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having HAS_TEST_RESULTS unset leads to a Windows CMD script syntax error.
Clean up a few other things while there:
%ERRORLEVEL%doesn't change between the test run and all of the subsequent uses.HAS_TEST_RESULTS=1Fixes #88353