Skip to content

Devirtualization with multiple guesses: JIT #86809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 1, 2023
Merged

Devirtualization with multiple guesses: JIT #86809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
aff9029
Implement multiple GDV for JIT
EgorBo May 26, 2023
862a23b
Clean up
EgorBo May 26, 2023
7ed025b
Clean up
EgorBo May 26, 2023
ce787ad
Clean up
EgorBo May 26, 2023
a815495
Merge branch 'main' of github.com:dotnet/runtime into multiple-gdv-jit
EgorBo May 27, 2023
03bc8f4
Fix asserts
EgorBo May 27, 2023
91fc31d
Update jitconfigvalues.h
EgorBo May 27, 2023
d104307
Merge branch 'main' of github.com:dotnet/runtime into multiple-gdv-jit
EgorBo May 31, 2023
03bda0d
Address feedback
EgorBo Jun 1, 2023
4dfb1b9
Address feedback
EgorBo Jun 1, 2023
61f61b2
Do `ClearInlineInfo` after we calculate elseBlock's likelihood - it u…
EgorBo Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/coreclr/jit/compiler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7128,9 +7128,10 @@ class Compiler
void pickGDV(GenTreeCall* call,
IL_OFFSET ilOffset,
bool isInterface,
CORINFO_CLASS_HANDLE* classGuess,
CORINFO_METHOD_HANDLE* methodGuess,
unsigned* likelihood);
CORINFO_CLASS_HANDLE* classGuesses,
CORINFO_METHOD_HANDLE* methodGuesses,
int* candidatesCount,
unsigned* likelihoods);

void considerGuardedDevirtualization(GenTreeCall* call,
IL_OFFSET ilOffset,
Expand Down
18 changes: 14 additions & 4 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12400,11 +12400,21 @@ void Compiler::gtDispTree(GenTree* tree,
printf(" (FramesRoot last use)");
}

if (((call->gtFlags & GTF_CALL_INLINE_CANDIDATE) != 0) &&
(call->GetSingleInlineCandidateInfo() != nullptr) &&
(call->GetSingleInlineCandidateInfo()->exactContextHnd != nullptr))
if ((call->gtFlags & GTF_CALL_INLINE_CANDIDATE) != 0)
{
printf(" (exactContextHnd=0x%p)", dspPtr(call->GetSingleInlineCandidateInfo()->exactContextHnd));
InlineCandidateInfo* inlineInfo;
if (call->IsGuardedDevirtualizationCandidate())
{
inlineInfo = call->GetGDVCandidateInfo(0);
}
else
{
inlineInfo = call->GetSingleInlineCandidateInfo();
}
if ((inlineInfo != nullptr) && (inlineInfo->exactContextHnd != nullptr))
{
printf(" (exactContextHnd=0x%p)", dspPtr(inlineInfo->exactContextHnd));
}
Copy link
Member Author

@EgorBo EgorBo May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are JitDump only, gtDispTree was not aware that a call might have more than a single candidate.

}

gtDispCommonEndLine(tree);
Expand Down
Loading