Fix a few downlevel TimeProvider issues #85346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephentoub
commented
Apr 25, 2023
stephentoub
commented
- Consistently null check the Timer stored in the state object
- Complete the a task canceled due to the CancellationToken with the CancellationToken
- Avoid an unnecessary closure in Delay
- Make TimeProvider.System.CreateTimer use Timer's ctor that takes duration/period rather than making a separate call to Change
- Consistently null check the Timer stored in the state object - Complete the a task canceled due to the CancellationToken with the CancellationToken - Avoid an unnecessary closure in Delay - Make TimeProvider.System.CreateTimer use Timer's ctor that takes duration/period rather than making a separate call to Change
ghost
added
the
needs-area-label
sebastienros
approved these changes
Apr 25, 2023
tarekgh
approved these changes
Apr 25, 2023
tarekgh
added
area-System.DateTime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-datetime Issue Details
|
This was referenced Apr 25, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.