Skip to content

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Apr 17, 2023

Since ioslike simulator x64 library lanes are looking healthy, try reenabling

This reverts commit 67b6e81.

@mdh1418
Copy link
Member Author

mdh1418 commented Apr 17, 2023

/azp run runtime-extra-plaftorms

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mdh1418
Copy link
Member Author

mdh1418 commented Apr 17, 2023

/azp run runtime-maccatalyst,runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@steveisok
Copy link
Member

The catalyst failure will be fixed by #84842

@mdh1418 mdh1418 marked this pull request as ready for review April 17, 2023 19:03
@mdh1418
Copy link
Member Author

mdh1418 commented Apr 17, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marek-safar marek-safar added the os-ios Apple iOS label May 29, 2023
@ghost
Copy link

ghost commented May 29, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Since ioslike simulator x64 library lanes are looking healthy, try reenabling

This reverts commit 67b6e81.

Author: mdh1418
Assignees: -
Labels:

area-Infrastructure-libraries, os-ios

Milestone: -

@steveisok steveisok self-requested a review June 5, 2023 03:13
@steveisok
Copy link
Member

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 84930 in repo dotnet/runtime

@steveisok
Copy link
Member

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 84930 in repo dotnet/runtime

@akoeplinger
Copy link
Member

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

steveisok commented Jun 7, 2023

NamedPipeTest_CreateServer.PipeOptions_FirstPipeInstanceWithSameNameReuse_Throws_UnauthorizedAccessException needs fixed.

System.ArgumentOutOfRangeException : The path '/Users/helix-runner/Library/Developer/CoreSimulator/Devices/92790E07-0212-4175-87AB-3F59CEEFF99F/data/Containers/Data/Application/C9BE5F0F-363D-4725-8439-6DF065A25458/tmp/CoreFxPipe_toz2mdfe.y1q' is of an invalid length for use with domain sockets on this platform.  The length must be between 1 and 104 characters, inclusive. (Parameter 'path')
Actual value was /Users/helix-runner/Library/Developer/CoreSimulator/Devices/92790E07-0212-4175-87AB-3F59CEEFF99F/data/Containers/Data/Application/C9BE5F0F-363D-4725-8439-6DF065A25458/tmp/CoreFxPipe_toz2mdfe.y1q.

@mkhamoyan I recall you addressing temp names such as this before. Was that for named pipes or file system?

Since it's one test, we might as well resolve it and then merge.

@mkhamoyan
Copy link
Contributor

mkhamoyan commented Jun 8, 2023

@steveisok we had several issues open for that (from brief looking found #51390, #67853).
In my PR #72935 , I tried to shorten pipe name but I was getting a permission denied error on the socket bind, then PR was closed as @directhex fixed it with #74927 . I think we can do same for this test case also , will l try locally.

@steveisok
Copy link
Member

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

@mkhamoyan the maccatalyst failures are IsolatedStorage ones. They pass for me locally, which does not make a whole lot of sense right now.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=303959&view=ms.vss-test-web.build-test-results-tab

@mkhamoyan
Copy link
Contributor

Works for me also locally. Maybe WipeStore doesn't clean old existing paths , will update it.

@mkhamoyan
Copy link
Contributor

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Contributor

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok steveisok merged commit 4475c57 into dotnet:main Jun 14, 2023
@steveisok steveisok deleted the reenable_arm64_ioslike_ci branch June 14, 2023 23:05
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants