[release/7.0-staging] Caching settings.pause_mode to avoid deadlock #84738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #84189 to release/7.0-staging /cc @cshung Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
approved these changes
Apr 18, 2023
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x. please get a code review.
jeffschwMSFT
added
the
Servicing-consider
Maoni0
approved these changes
Apr 18, 2023
rbhanda
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #84189 to release/7.0-staging
/cc @cshung
Customer Impact
Processes may deadlock if they are using NoGCRegion. This is reported as #84096. This explained the root cause and the fix. Since it is a race between a GC completing and stopping a NoGCRegion, any NoGCRegion user could have hit this by chance.
Testing
This change was merged into the main branch 3 weeks ago and hit no issues associated with that, and it has gone through the regular GC testing as reported here. Running the NoGCRegion CI test under Server GC routinely reproduces the deadlock and I verified that the deadlock is gone with this fix.
Risk
The change only caches a flag, it is unlikely to cause any regression.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.