Skip to content

Conversation

@lambdageek
Copy link
Member

@lambdageek lambdageek commented Mar 13, 2023

For hot reload it would be nice to rewrite this part of find_method_in_class using the mono_class_get_methods iterator. But the iterator contract is to return NULL when we're done iterating. So we might be changing something here.

Does modern code ever see NULL at this point? Apparently not. Assert that that is the case.

@ghost ghost assigned lambdageek Mar 13, 2023
@ghost
Copy link

ghost commented Mar 13, 2023

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

WIP hack. For hot reload it would be nice to rewrite this part of find_method_in_class using the mono_class_get_methods iterator. But the iterator contract is to return NULL when we're done iterating. So we might be changing something here.

Does modern code ever see NULL at this point?

Author: lambdageek
Assignees: lambdageek
Labels:

area-AssemblyLoader-mono

Milestone: -

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant