Skip to content

ObjectFactory should verify against a null serviceProvider #82739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

ObjectFactory should verify against a null serviceProvider #82739

merged 1 commit into from
Mar 15, 2023

Conversation

@pedrobsaila
Copy link
Contributor

@pedrobsaila pedrobsaila commented Feb 27, 2023

Fixes #82315

@ghost ghost added area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member labels Feb 27, 2023
@ghost
Copy link

ghost commented Feb 27, 2023

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #82315

Author: pedrobsaila
Assignees: -
Labels:

area-Extensions-DependencyInjection
Milestone: -

@steveharter
Copy link
Contributor

steveharter commented Mar 13, 2023

Thanks

steveharter
steveharter reviewed Mar 13, 2023
View reviewed changes
...libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ActivatorUtilitiesTests.cs
Assert.Throws<ArgumentNullException>(() => ActivatorUtilities.CreateInstance<ClassWithABCS>(null, "hello"));
}

[Fact]
Copy link
Contributor

@steveharter steveharter Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test

@steveharter steveharter added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Mar 13, 2023
@steveharter steveharter merged commit 32ebb66 into dotnet:main Mar 15, 2023
@pedrobsaila pedrobsaila deleted the 82315 branch March 15, 2023 13:34
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2023
@ericstj ericstj added this to the 8.0.0 milestone Jun 28, 2023
@steveharter
Copy link
Contributor

steveharter commented Oct 16, 2023

Breaking change reference at dotnet/docs#34158

@steveharter steveharter removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@steveharter steveharter steveharter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@steveharter steveharter

Labels

area-Extensions-DependencyInjection community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

ObjectFactory should verify against a null serviceProvider

3 participants

@pedrobsaila @steveharter @ericstj