Skip to content

Disable adaptive loop alignment for known hot methods #82635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Disable adaptive loop alignment for known hot methods #82635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8d208d
Disable adaptive loop alignment for PGO
EgorBo Feb 24, 2023
e19d00f
spmi change
EgorBo Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/coreclr/jit/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2454,6 +2454,12 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
opts.compJitUnrollLoopMaxIterationCount = DEFAULT_UNROLL_LOOP_MAX_ITERATION_COUNT;
#endif

if (opts.compJitAlignLoopAdaptive && fgHaveSufficientProfileWeights())
{
JITDUMP("Disable adaptive loop alignment known hot methods")
opts.compJitAlignLoopAdaptive = false;
}

#ifdef TARGET_XARCH
if (opts.compJitAlignLoopAdaptive)
{
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/scripts/superpmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,7 +1538,7 @@ def replay_with_asm_diffs(self):

# These vars are force overridden in the SPMI runs for both the base and diff, always.
replay_vars = {
"DOTNET_JitAlignLoops": "0", # disable loop alignment to filter noise
"DOTNET_JitAlignLoops": "1", # disable loop alignment to filter noise
"DOTNET_JitEnableNoWayAssert": "1",
"DOTNET_JitNoForceFallback": "1",
}
Expand Down