-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[JIT] On importing a CEE_INITOBJ for a simd, construct a VecCon(0) #81982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsWhen handle CEE_INITOBJ in the importer, if we know that the type is a simd type, then constructor a
|
|
@dotnet/jit-contrib this is ready. cc @tannergooding @kunalspathak A few improvements |
SingleAccretion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is great to make the zero-init form for vectors canonical with CNS_VEC, but we should make this change everywhere and fully disallow ASG(simd, CNS_INT 0). This will allow for some code simplification (e. g. in VN, or the recent local morph fix).
I agree, we will make another PR to handle it. @tannergooding knows of the several places to do this so I'll let him handle it. |
Co-authored-by: SingleAccretion <[email protected]>
tannergooding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we should have an issue tracking the other cleanup so we can get to the desired outcome of no more ASG(SIMD, 0)
|
@dotnet/jit-contrib this is ready PTAL @jakobbotsch |
When we handle
CEE_INITOBJin the importer, if we know that the type is a simd type, then construct aVecCon(0)for the zero-initialization instead of anIntCon(0).