Fix size regression from enum sorting #79845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a specialized comparer instead of `Comparer<T>.Default` that brings the implementation of `IComparable.ComparerTo` on everything. Also get rid of the generic virtual method call.
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsUse a specialized comparer instead of Saves 0.9% on Hello World. Contributes to #79437.
|
jkotas
reviewed
Dec 21, 2022
...ivate.CoreLib/src/System/Reflection/Runtime/General/ReflectionCoreCallbacksImplementation.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 21, 2022
...ivate.CoreLib/src/System/Reflection/Runtime/General/ReflectionCoreCallbacksImplementation.cs
Outdated
Show resolved
Hide resolved
...ivate.CoreLib/src/System/Reflection/Runtime/General/ReflectionCoreCallbacksImplementation.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <[email protected]>
...ivate.CoreLib/src/System/Reflection/Runtime/General/ReflectionCoreCallbacksImplementation.cs
Outdated
Show resolved
Hide resolved
…tion/Runtime/General/ReflectionCoreCallbacksImplementation.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a specialized comparer instead of
Comparer<T>.Defaultthat brings the implementation ofIComparable.ComparerToon everything. Also get rid of the generic virtual method call.Saves 0.9% on Hello World.
Contributes to #79437.