[release/6.0] [mono][interp] Add unbox when calling valuetype method through delegate #79819
Conversation
If we are calling an open instance delegate, where the target method is on a valuetype, we will need to unbox this pointer.
BrzVlad
added
Servicing-consider
|
Tagging subscribers to this area: @BrzVlad Issue DetailsIf we are calling an open instance delegate, where the target method is on a valuetype, we will need to unbox this pointer. Backport of #79445 Fixes #79354 Customer ImpactMAUI iOS applications making use of the popular TestingVerified fix on sample app provided in the bug report and created a simple test case that is included in our suite. RiskLow. The fix only touches the code path for a very specific type of delegate invocation pattern which was previously handled incorrectly before.
|
SamMonoRT
added
Servicing-approved
|
/cc @carlossanlop - approved via Tactics email. @BrzVlad - please confirm CI failures are not related. Thanks. |
|
The failures don't look related and I see them also on other PRs so this is good |
|
Approved by Tactics (6.0.14). |
ghost
locked as resolved and limited conversation to collaborators
4 participants
If we are calling an open instance delegate, where the target method is on a valuetype, we will need to unbox this pointer.
Backport of #79445
Fixes #79354
Customer Impact
MAUI iOS applications making use of the popular
AutoMapperNuGet library can crash in debug builds. Workaround is to disable mono interpreter and implicitly hot reload. Other platforms using interpreter, like blazor wasm, can potentially hit this issue even in Release.Testing
Verified fix on sample app provided in the bug report and created a simple test case that is included in our suite.
Risk
Low. The fix only touches the code path for a very specific type of delegate invocation pattern which was previously handled incorrectly before.