-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[mono][interp] Add unbox when calling valuetype method through delegate #79445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4516c27
[mono][interp] Add unbox when calling valuetype method through delegate
BrzVlad 846f4ea
[mono][interp] Remove redundant check
BrzVlad 904d9c0
[mono][interp] Remove dead opcode
BrzVlad 5e828d6
[tests] Add regression test
BrzVlad e4affef
[tests] Disable test on fullaot
BrzVlad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
src/tests/JIT/Regression/JitBlue/Runtime_79354/Runtime_79354.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Reflection; | ||
|
|
||
| public interface IGetContents { | ||
| (string, int, string) GetContents(); | ||
| } | ||
|
|
||
| public struct MyStruct : IGetContents { | ||
| public string s1; | ||
| public int a; | ||
| public string s2; | ||
|
|
||
| public (string, int, string) GetContents() | ||
| { | ||
| return (s1, a, s2); | ||
| } | ||
| } | ||
|
|
||
| public class Program { | ||
|
|
||
| public delegate (string, int, string) MyDelegate(IGetContents arg); | ||
|
|
||
| public static int Main(string[] args) | ||
| { | ||
| MyStruct str = new MyStruct(); | ||
| str.s1 = "test1"; | ||
| str.a = 42; | ||
| str.s2 = "test2"; | ||
|
|
||
| MethodInfo mi = typeof(IGetContents).GetMethod("GetContents"); | ||
| MyDelegate func = (MyDelegate)mi.CreateDelegate(typeof(MyDelegate)); | ||
|
|
||
| (string c1, int c2, string c3) = func(str); | ||
| if (c1 != "test1") | ||
| return 1; | ||
| if (c2 != 42) | ||
| return 2; | ||
| if (c3 != "test2") | ||
| return 3; | ||
| return 100; | ||
| } | ||
| } |
9 changes: 9 additions & 0 deletions
9
src/tests/JIT/Regression/JitBlue/Runtime_79354/Runtime_79354.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <Optimize>True</Optimize> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="$(MSBuildProjectName).cs" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first check was not needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it seems redundant. I can't think why it would be needed. If you can think on why it would be wrong let me know. I don't plan to backport this part of the change though.