Skip to content

[wasm] propagate aborted startup to top most promise #78644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

[wasm] propagate aborted startup to top most promise #78644

merged 1 commit into from
Nov 22, 2022

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Nov 21, 2022

fixes #77882

@pavelsavara pavelsavara added this to the 8.0.0 milestone Nov 21, 2022
@pavelsavara pavelsavara requested a review from maraf November 21, 2022 16:55
@pavelsavara pavelsavara self-assigned this Nov 21, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #77882

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara marked this pull request as ready for review November 22, 2022 09:36
@pavelsavara pavelsavara requested a review from lewing as a code owner November 22, 2022 09:36
@pavelsavara pavelsavara merged commit ea4f2cc into dotnet:main Nov 22, 2022
@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 23, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3532312303

@github-actions github-actions bot mentioned this pull request Nov 23, 2022
Merged
@radical
Copy link
Member

radical commented Nov 23, 2022

What does the failure look like after this fix?

@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2022
@pavelsavara pavelsavara deleted the wasm_propagate_startup_errors branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

dotnet.create() does not throw error when WebAssembly.instantiateStreaming() fails

3 participants

@pavelsavara @radical @maraf