Skip to content

new RID: wasi-wasm #78376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Nov 16, 2022
Merged

new RID: wasi-wasm #78376

merged 33 commits into from
Nov 16, 2022

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Nov 15, 2022 •
edited
Loading

  • msbuild: TargetsWasi, mono.wasiruntime subset
  • differentiate wasm on Browser from wasm on Wasi, renamed IsBrowserProject
  • build shell files
  • initial CMake files
  • CI pipeline platform WASI_wasm
  • OperatingSystem.OSPlatformName ="WASI"
  • OperatingSystem.IsWasi()

Fixes #77780
Related API #78389
Related arcade dotnet/arcade#11641

This is split off from #77823 for smaller and easier review. This PR is not building WASI target yet, it's just prep step.

@pavelsavara
new RID: wasi-wasm
7bbd5ee 
- msbuild: TargetsWasi, mono.wasiruntime subset
- differentiate wasm on Browser from wasm on Wasi, renamed IsBrowserProject
- build shell files
- initial CMake files
- CI pipeline platform Wasi_wasm
- OperatingSystem.OSPlatformName ="Wasi"
- OperatingSystem.IsWasi()
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono labels Nov 15, 2022
@pavelsavara pavelsavara added this to the 8.0.0 milestone Nov 15, 2022
@pavelsavara pavelsavara self-assigned this Nov 15, 2022
@ghost
Copy link

ghost commented Nov 15, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • msbuild: TargetsWasi, mono.wasiruntime subset
  • differentiate wasm on Browser from wasm on Wasi, renamed IsBrowserProject
  • build shell files
  • initial CMake files
  • CI pipeline platform Wasi_wasm
  • OperatingSystem.OSPlatformName ="Wasi"
  • OperatingSystem.IsWasi()

Fixes #77780

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-Build-mono
Milestone: 8.0.0

@ghost
Copy link

ghost commented Nov 15, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@vargaz
Copy link
Contributor

vargaz commented Nov 15, 2022

wasi is a abbrev for Webassembly System Interface, so the name should probably be wasi or WASI.

vargaz
vargaz reviewed Nov 15, 2022
View reviewed changes
@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 15, 2022

wasi is a abbrev for Webassembly System Interface, so the name should probably be wasi or WASI.

I changed it in places which refer to OS and are not all lower-case. Is that what you asked for ? @vargaz

@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 15, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 15, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review November 15, 2022 14:11
marek-safar
marek-safar reviewed Nov 15, 2022
View reviewed changes
akoeplinger
akoeplinger reviewed Nov 15, 2022
View reviewed changes
@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 16, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 16, 2022

Azure Pipelines successfully started running 1 pipeline(s).

akoeplinger
akoeplinger approved these changes Nov 16, 2022
View reviewed changes
@akoeplinger
Copy link
Member

akoeplinger commented Nov 16, 2022

I noticed you haven't touched the .csproj files that have $(NetCoreAppCurrent)-Browser, is that intentional?

@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 16, 2022

I noticed you haven't touched the .csproj files that have $(NetCoreAppCurrent)-Browser, is that intentional?

Yes, I want to merge it in multiple PRs. The bleeding edge being #77823

pavelsavara and others added 9 commits November 16, 2022 12:46
@pavelsavara @akoeplinger
Update eng/build.sh
3e560f3 
Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara @akoeplinger
Update Directory.Build.props
9db9d12 
Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara @akoeplinger
Update eng/native/build-commons.sh
f968e7d 
Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara @akoeplinger
Update src/libraries/System.Private.CoreLib/src/System.Private.CoreLi…
7fb65a9 
…b.Shared.projitems

Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara @akoeplinger
Update eng/native/gen-buildsys.cmd
b8591f2 
Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara @akoeplinger
Update eng/native/gen-buildsys.cmd
69fdb03 
Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara @akoeplinger
Update src/coreclr/scripts/coreclr_arguments.py
87b2d35 
Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara @akoeplinger
Update src/native/libs/build-native.sh
bbed97d 
Co-authored-by: Alexander Köplinger <[email protected]>
@pavelsavara
fix
0828301
@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 16, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 16, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara requested a review from lewing as a code owner November 16, 2022 12:54
@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 16, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 16, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit 27c19c3 into dotnet:main Nov 16, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2022
@pavelsavara pavelsavara deleted the wasm_rid branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safar marek-safar marek-safar left review comments

@radical radical radical approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@thaystg thaystg thaystg approved these changes

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@radekdoulik radekdoulik Awaiting requested review from radekdoulik

@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

+1 more reviewer

@vargaz vargaz vargaz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-Build-mono new-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[wasi] Add new RID for WASI

6 participants

@pavelsavara @vargaz @radical @akoeplinger @marek-safar @thaystg