[release/7.0] [wasm][debugger] Don't escape accented letters #78217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #78171 to release/7.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
Please, do not merge. |
radical
added
the
NO-MERGE
thaystg
changed the title
radical
removed
the
NO-MERGE
thaystg
changed the title
|
This was approved by Tactics via email and is signed off by area owner. No OOB package authoring changes needed for this. |
carlossanlop
added
Servicing-approved
|
Failures happened all in the installer legs, none seem related to this change (it's all network/infra issues). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #78171 to release/7.0
/cc @thaystg
Customer Impact
When the customer adds a breakpoint in a file that contains any special character like (swedish characters) and the breakpoint is hit, the file is not opened correctly on VS.
Testing
Manually tested using a Blazor app, adding special characters in the folder, in the project name and in the source file name.
Risk
Low risk, do not escape all the letters and not only the ones unaccented.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.