[Release/7.0] Delete dangling thread session states #76691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Johan Lorensson <[email protected]>
davmason
changed the title
jeffschwMSFT
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
approved. please get a code review and can you include more details from #76431 in this description. we will take for consideration in 7 ga
jeffschwMSFT
added
Servicing-approved
|
@davmason can you take a look at the ci failures? |
|
The leg that failed is building the native test components that I didn't touch, and I don't see an obvious failure in the logs. I reset it to see if it will pass on retry |
|
Approved, signed off, CI passed on retry. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #76431 to 7.0
Customer Impact
Customers that have many threads and short lived sessions are vulnerable to this issue and there is no workaround. They will experience random crashes.
Risk
Low, it is a targeted fix that is easy to reason about
Testing
Manual testing by our team