Skip to content

Ensure NI_Vector256_GetLower has the right simdSize and improve codegen slightly #76456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

Ensure NI_Vector256_GetLower has the right simdSize and improve codegen slightly #76456

merged 1 commit into from
Oct 3, 2022

Conversation

@tannergooding
Copy link
Member

@tannergooding tannergooding commented Sep 30, 2022

No description provided.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 30, 2022
@ghost ghost assigned tannergooding Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@tannergooding tannergooding mentioned this pull request Sep 30, 2022
Closed
@tannergooding tannergooding marked this pull request as ready for review September 30, 2022 17:35
@BruceForstall BruceForstall mentioned this pull request Sep 30, 2022
Merged
@tannergooding
Copy link
Member Author

tannergooding commented Oct 2, 2022

CC. @dotnet/jit-contrib. Small fix.

Regressions are because we now "correctly" emit vzeroupper as part of the method epilogue in some cases. In general vzeroupper is a place where we insert it far too frequently today and where we are tracking improving that via #11496

@tannergooding tannergooding merged commit bce23ab into dotnet:main Oct 3, 2022
@tannergooding tannergooding deleted the fix-getlower branch October 3, 2022 12:22
@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBo EgorBo EgorBo approved these changes

Assignees

@tannergooding tannergooding

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tannergooding @EgorBo