Skip to content

[release/7.0] fix div by zero in gen size calculation #76334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022
Merged

[release/7.0] fix div by zero in gen size calculation #76334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coreclr/gc/gc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3171,7 +3171,8 @@ gc_heap::dt_high_frag_p (gc_tuning_point tp,
#ifndef MULTIPLE_HEAPS
if (gen_number == max_generation)
{
float frag_ratio = (float)(dd_fragmentation (dynamic_data_of (max_generation))) / (float)generation_size (max_generation);
size_t maxgen_size = generation_size (max_generation);
float frag_ratio = (maxgen_size ? ((float)dd_fragmentation (dynamic_data_of (max_generation)) / (float)maxgen_size) : 0.0f);
if (frag_ratio > 0.65)
{
dprintf (GTC_LOG, ("g2 FR: %d%%", (int)(frag_ratio*100)));
Expand All @@ -3183,7 +3184,8 @@ gc_heap::dt_high_frag_p (gc_tuning_point tp,
ret = (fr > dd_fragmentation_limit(dd));
if (ret)
{
fragmentation_burden = (float)fr / generation_size (gen_number);
size_t gen_size = generation_size (gen_number);
fragmentation_burden = (gen_size ? ((float)fr / (float)gen_size) : 0.0f);
ret = (fragmentation_burden > dd_v_fragmentation_burden_limit (dd));
}
dprintf (GTC_LOG, ("h%d: gen%d, frag is %Id, alloc effi: %d%%, unusable frag is %Id, ratio is %d",
Expand Down