Skip to content

Conversation

@thaystg
Copy link
Member

@thaystg thaystg commented Sep 23, 2022

Backport of #76072 to release/6.0

/cc @thaystg

Customer Impact

It was crashing the debugger when an app has another .NET Wasm instance in a service worker

Testing

Manually tested

Risk

Low Risk, only ignoring a session id that is not known.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost ghost added the area-Debugger-mono label Sep 23, 2022
@ghost ghost assigned thaystg Sep 23, 2022
@ghost
Copy link

ghost commented Sep 23, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76072 to release/6.0

/cc @thaystg

Customer Impact

It was crashing the debugger when an app has another .NET Wasm instance in a service worker

Testing

Manually tested

Risk

Low Risk, only ignoring a session id that is not known.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg requested a review from lewing September 23, 2022 14:51
@lewing lewing added the Servicing-consider Issue for next servicing release review label Sep 23, 2022
@lewing
Copy link
Member

lewing commented Sep 23, 2022

timeouts are not related

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 27, 2022
@rbhanda rbhanda added this to the 6.0.11 milestone Sep 27, 2022
@carlossanlop
Copy link
Contributor

Approved. Signed off. CI failures confirmed as unrelated. No OOB package authoring changes needed. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 754d1c2 into dotnet:release/6.0 Oct 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants