Fix edge cases of getting attribute data from syntax #75727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two customer-discovered edge cases that were causing analyzer crashes. Fixes dotnet#75681 Fixes dotnet#75706
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned
Member
Author
|
/backport to release/7.0-rc2 |
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Contributor
|
Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3064166844 |
tannergooding
approved these changes
Sep 15, 2022
stephentoub
reviewed
Sep 16, 2022
...ries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/SyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 16, 2022
...ries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/SyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Sep 16, 2022
Co-authored-by: Stephen Toub <[email protected]>
Member
Author
|
Linux arm64 NativeAOT timeout is a known issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two customer-discovered edge cases that were causing analyzer crashes.
Fixes #75681
Fixes #75706