-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Product dependencies in Versions.props must be on the latest patch version for libraries dependencies #73871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product dependencies in Versions.props must be on the latest patch version for libraries dependencies #73871
Conversation
|
@radical @lambdageek are you ok with bumping the System.Reflection.Metadata.LoadContext package version to the latest stable one? You own the code that could be impacted. @MichaelSimons merely introduced the package to support |
@carlossanlop I think that's fine. in the past we've had problems with depending on rolling build versions of out of band packages which led to breakage when our task would run on .NET Framework inside VS msbuild. (see the comment below), but stable versions should be ok, I think runtime/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj Lines 23 to 26 in 667c170
|
|
Yeah the concern here is that the task continues to work with VS/msbuild |
|
@lewing if I bump the version of the package, how do we verify it is still working with VS/msbuild? |
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@radical any concerns about the wasm CI failures? I'm looking at the rest. |
|
re:wasm, can't say for sure yet. I'm having trouble even loading the console logs from the helix test runs. |
|
@carlossanlop Can you merge |
…rsion for libraries dependencies
|
@radical done. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This will have to be backported to rc1. |
|
/backport to release/7.0-rc1 |
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2870765762 |
Addresses item no. 2 of: #72111
Pending clarification:
This PR introduced the entry a few days ago but with an older version than the latest stable released version. Waiting for @radical and/or @lewing for confirmation that we can bump it to the latest stable version, per this comment.
Changed (newer stable version found):
Unchanged (already in latest stable version):
Ignored: