Skip to content

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Aug 12, 2022

Addresses item no. 2 of: #72111

Pending clarification:

Changed (newer stable version found):

Unchanged (already in latest stable version):

Ignored:

  • StyleCopAnalyzersVersion
  • SystemTextJsonVersion
  • runtimenativeSystemIOPortsVersion

@ghost
Copy link

ghost commented Aug 12, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Addresses item no. 2 of: #72111

Pending clarification:

Changed (newer stable version found):

Unchanged (already in latest stable version):

Ignored:

  • StyleCopAnalyzersVersion
  • SystemTextJsonVersion
  • runtimenativeSystemIOPortsVersion
Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure-libraries

Milestone: 7.0.0

@carlossanlop
Copy link
Contributor Author

@radical @lambdageek are you ok with bumping the System.Reflection.Metadata.LoadContext package version to the latest stable one? You own the code that could be impacted.

@MichaelSimons merely introduced the package to support source-build, which doesn't really care what version is indicated here, as it ends up overriding the value.

@carlossanlop carlossanlop requested review from lewing and radical August 12, 2022 23:25
@lambdageek
Copy link
Member

@radical @lambdageek are you ok with bumping the System.Reflection.Metadata.LoadContext package version to the latest stable one? You own the code that could be impacted.

@carlossanlop I think that's fine. in the past we've had problems with depending on rolling build versions of out of band packages which led to breakage when our task would run on .NET Framework inside VS msbuild. (see the comment below), but stable versions should be ok, I think

<PackageReference Include="System.Reflection.MetadataLoadContext" Version="$(SystemReflectionMetadataLoadContextVersion)" />
<!-- When we requested a version that is newer than what comes with Visual Studio version of msbuild, it causes problems with
running the task from inside VS. Therefore, we are using the moving version only for source-build. -->

@lewing
Copy link
Member

lewing commented Aug 14, 2022

Yeah the concern here is that the task continues to work with VS/msbuild

@carlossanlop
Copy link
Contributor Author

@lewing if I bump the version of the package, how do we verify it is still working with VS/msbuild?

@carlossanlop

This comment was marked as resolved.

@radical
Copy link
Member

radical commented Aug 15, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor Author

@radical any concerns about the wasm CI failures? I'm looking at the rest.

@radical
Copy link
Member

radical commented Aug 15, 2022

re:wasm, can't say for sure yet. I'm having trouble even loading the console logs from the helix test runs.

@radical
Copy link
Member

radical commented Aug 15, 2022

@carlossanlop Can you merge main? It has wasm fixes now.

@carlossanlop
Copy link
Contributor Author

@radical done.

@radical
Copy link
Member

radical commented Aug 16, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Contributor Author

This will have to be backported to rc1.

@carlossanlop carlossanlop merged commit 5b5b02d into dotnet:main Aug 16, 2022
@carlossanlop
Copy link
Contributor Author

/backport to release/7.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2870765762

@carlossanlop carlossanlop deleted the BumpLibrariesDepsVersions branch August 16, 2022 20:08
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants