Annotating System.Formats.Asn1 library for Aot

[LakshanF]

Instead of using Marshal.SizeOf API which causes an AOT warning, wrote a separate implementation as suggested in feedback below to read the size of an enum's underlying type

Enabled the test project to run in AOT rolling run by excluding test scenarios that rely on creating a delegate that has a boxed by-ref parameter, issue #72548 tracks this failure

[ghost]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-formats-asn1, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Propagated RequiresDynamicCode warning for the Marshal.SizeOf API for the library to be warning free

The generic APIs version of these APIs could be made to use the generic version and be safe but currently they are generating warnings since they go through the non-generic APIs.

Author:	LakshanF
Assignees:	LakshanF
Labels:	new-api-needs-documentation, area-System.Formats.Asn1, area-NativeAOT-coreclr
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/area-system-formats-asn1, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Propagated RequiresDynamicCode warning for the Marshal.SizeOf API for the library to be warning free

The generic APIs version of these APIs could be made to use the generic version and be safe but currently they are generating warnings since they go through the non-generic APIs.

Author:	LakshanF
Assignees:	LakshanF
Labels:	new-api-needs-documentation, area-System.Formats.Asn1, area-NativeAOT-coreclr
Milestone:	-

[jkotas]

Marshal.SizeOf API for the library to be warning free

This is easy to change to not use Marshal.SizeOf. For example, define following method somewhere:

static int GetPrimitiveIntegerSize(Type primitiveType)
{
    if (primitiveType == typeof(byte) || primitiveType == typeof(sbyte))
        return 1;
    if (primitiveType == typeof(short) || primitiveType == typeof(ushort))
        return 2;
    if (primitiveType == typeof(int) || primitiveType == typeof(uint))
        return 4;
    if (primitiveType == typeof(long) || primitiveType == typeof(ulong))
        return 8;
    return 0;
}

and use it instead of Marshal.SizeOf.

[bartonjs]

static int GetPrimitiveIntegerSize(Type primitiveType)

I recommend approximately

runtime/src/libraries/System.Formats.Asn1/src/System/Formats/Asn1/AsnDecoder.cs

Lines 467 to 469 in 62eb291

	}
	/// <summary>

ish

[jkotas]

LGTM. Thanks!

[LakshanF]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[bartonjs]

Rescinding approval based on unresolved feedback in new changes.

[LakshanF]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

LGTM otherwise

[LakshanF]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).