Skip to content

Make RateLimiterOptions follow Options pattern #72530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 61 commits into from
Jul 26, 2022
Merged

Make RateLimiterOptions follow Options pattern #72530

merged 61 commits into from
Jul 26, 2022

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jul 20, 2022

Implements #72389

@ghost ghost assigned wtgodbe Jul 20, 2022
@ghost
Copy link

ghost commented Jul 20, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements #72389

Author: wtgodbe
Assignees: wtgodbe
Labels:

area-System.Threading
Milestone: -

BrennanConroy
BrennanConroy reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted common typos, just highlighted a couple cases

martincostello
martincostello reviewed Jul 22, 2022
View reviewed changes
BrennanConroy
BrennanConroy reviewed Jul 22, 2022
View reviewed changes
wtgodbe and others added 10 commits July 22, 2022 14:54
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
dd9eca1 
…ng/RateLimiting/ConcurrencyLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
8b11ec5 
…ng/RateLimiting/FixedWindowRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
3007da6 
…ng/RateLimiting/FixedWindowRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
1857521 
…ng/RateLimiting/SlidingWindowRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
02831bd 
…ng/RateLimiting/SlidingWindowRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
7966a36 
…ng/RateLimiting/TokenBucketRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
2c90029 
…ng/RateLimiting/TokenBucketRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
855fe11 
…ng/RateLimiting/TokenBucketRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe @BrennanConroy
Update src/libraries/System.Threading.RateLimiting/src/System/Threadi…
c31d883 
…ng/RateLimiting/TokenBucketRateLimiterOptions.cs

Co-authored-by: Brennan <[email protected]>
@wtgodbe
Fix checks, add test
8fb231d
@runfoapp runfoapp bot mentioned this pull request Jul 25, 2022
Closed
@wtgodbe wtgodbe merged commit 124ba53 into main Jul 26, 2022
@wtgodbe wtgodbe deleted the wtgodbe/OptionsPattern branch July 26, 2022 16:28
@dougbu dougbu mentioned this pull request Jul 27, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73

+1 more reviewer

@martincostello martincostello martincostello left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wtgodbe wtgodbe

Labels

area-System.Threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wtgodbe @martincostello @BrennanConroy