[QUIC] Listener AcceptConnectionAsync propagates errors from failed handshake #72390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIf there was a validation error with Fixes #72160
|
rzikm
approved these changes
Jul 19, 2022
Member
rzikm
left a comment
rzikm
left a comment
There was a problem hiding this comment.
LGTM, appart from minor change.
src/libraries/System.Net.Quic/src/System/Net/Quic/QuicListener.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Failure is #72429 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was a validation error with
QuicServerConnectionOptionsor a failure duringConnectionOptionsCallbackor a handshake failure, it will no get propagated fromAcceptConnectionAsync. Originally, that error would get just logged and swallowed, so that if listener user made a mistake they would have a hard time diagnosing it.Fixes #72160