Skip to content

Refactor wasmappbuilder's System.Text.Json reference to use a versions.props property #70582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2022
Merged

Refactor wasmappbuilder's System.Text.Json reference to use a versions.props property #70582

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfd3c8f
Refactor wasmappbuilder's System.Text.Json version reference to use a…
MichaelSimons Jun 10, 2022
f899782
Merge branch 'main' of https://github.com/dotnet/runtime into wasmapp…
MichaelSimons Jul 27, 2022
90b6498
Update per code review and refactor MetadataLoadContext version
MichaelSimons Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tasks/WasmAppBuilder/WasmAppBuilder.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<PackageReference Include="Microsoft.Build" Version="$(MicrosoftBuildVersion)" />
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MicrosoftBuildTasksCoreVersion)" />
<PackageReference Include="System.Reflection.MetadataLoadContext" Version="4.7.1" />
<PackageReference Include="System.Text.Json" Version="6.0.0" PrivateAssets="all" />
<PackageReference Include="System.Text.Json" Version="$(SystemTextJsonVersion)" PrivateAssets="all" />
Copy link
Contributor

@kasperk81 kasperk81 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<PackageReference Include="System.Text.Json" Version="$(SystemTextJsonVersion)" PrivateAssets="all" />
<!-- When we requested a version that is newer than what comes with Visual Studio version of msbuild, it causes problems with
running the task from inside VS. Therefore, we are using the moving version only for source-build. -->
<PackageReference Include="System.Text.Json" Condition="'$(DotNetBuildFromSource)' != 'true'" Version="6.0.0" PrivateAssets="all" />
<PackageReference Include="System.Text.Json" Condition="'$(DotNetBuildFromSource)' == 'true'" Version="$(SystemTextJsonVersion)" PrivateAssets="all" />

@lambdageek this?

Copy link
Member

@lambdageek lambdageek Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable to me, thanks!

Copy link
Member Author

@MichaelSimons MichaelSimons Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the suggested pattern.

</ItemGroup>

<Target Name="GetFilesToPackage" Returns="@(FilesToPackage)">
Expand Down