Delete a few dependencies on field sequences #69991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIn preparation for deleting the "sequence" part of the field sequence. We're expecting a small number of diffs from the last commit.
|
Contributor
Author
|
@dotnet/jit-contrib |
Or, rather, restores them better in case they were lost from FIELD nodes.
Two small positive diffs where the following tree:
IND bool
ADDR [FieldSeq]
LCL_VAR bool
Is now folded into LCL_VAR instead of LCL_FLD.
SingleAccretion
force-pushed
the
No-Field-Seq-Upstream
branch
from
8d66797 to
6005ccc
Compare
BruceForstall
approved these changes
Jun 7, 2022
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM. Running jitstress.
Contributor
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for deleting the "sequence" part of the field sequence.
A small number of diffs from the last commit.