Skip to content

Conversation

@jakobbotsch
Copy link
Member

In #67238 I have changed calls to show more types of arguments in jit dumps, e.g. for a call i.Foo(1, 2) to an interface method S24 Foo(int a, int b); we now show

N012 ( 30, 30) [000003] SACXG-------                          CALLV stub void   I.Foo
N007 (  3,  3) [000005] ------------ retbuf in rdx          ├──▌  ADDR      long  
N006 (  3,  2) [000004] D------N----                          └──▌  LCL_VAR   struct<S24, 24>(RB) V02 tmp1         
N008 (  3,  2) [000000] ------------ this in rcx            ├──▌  LCL_VAR   ref    V00 arg0         
N009 (  2, 10) [000010] H----------- vsd cell in r11        ├──▌  CNS_INT(h) long   0x7ffa20c80008 ftn REG r11
N010 (  1,  1) [000001] ------------ arg3 in r8             ├──▌  CNS_INT   int    1
N011 (  1,  1) [000002] ------------ arg4 in r9             └──▌  CNS_INT   int    2

instead of

N012 ( 30, 30) [000003] SACXG-------                CALLV stub void   I.Foo
N007 (  3,  3) [000005] ------------ arg2 in rdx  ├──▌  ADDR      long  
N006 (  3,  2) [000004] D------N----                └──▌  LCL_VAR   struct<S24, 24>(RB) V02 tmp1         
N008 (  3,  2) [000000] ------------ this in rcx  ├──▌  LCL_VAR   ref    V00 arg0         
N009 (  2, 10) [000010] H----------- arg1 in r11  ├──▌  CNS_INT(h) long   0x7ffa31320008 ftn REG r11
N010 (  1,  1) [000001] ------------ arg3 in r8   ├──▌  CNS_INT   int    1
N011 (  1,  1) [000002] ------------ arg4 in r9   └──▌  CNS_INT   int    2

I had to increase the margin by a bit to fit this new info and I did not notice that this string also needed to change.

cc @dotnet/jit-contrib

@ghost ghost assigned jakobbotsch Apr 15, 2022
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 15, 2022
@ghost
Copy link

ghost commented Apr 15, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

In #67238 I have changed calls to show more types of arguments in jit dumps, e.g. for a call i.Foo(1, 2) to an interface method S24 Foo(int a, int b); we now show

N012 ( 30, 30) [000003] SACXG-------                          CALLV stub void   I.Foo
N007 (  3,  3) [000005] ------------ retbuf in rdx          ├──▌  ADDR      long  
N006 (  3,  2) [000004] D------N----                          └──▌  LCL_VAR   struct<S24, 24>(RB) V02 tmp1         
N008 (  3,  2) [000000] ------------ this in rcx            ├──▌  LCL_VAR   ref    V00 arg0         
N009 (  2, 10) [000010] H----------- vsd cell in r11        ├──▌  CNS_INT(h) long   0x7ffa20c80008 ftn REG r11
N010 (  1,  1) [000001] ------------ arg3 in r8             ├──▌  CNS_INT   int    1
N011 (  1,  1) [000002] ------------ arg4 in r9             └──▌  CNS_INT   int    2

instead of

N012 ( 30, 30) [000003] SACXG-------                CALLV stub void   I.Foo
N007 (  3,  3) [000005] ------------ arg2 in rdx  ├──▌  ADDR      long  
N006 (  3,  2) [000004] D------N----                └──▌  LCL_VAR   struct<S24, 24>(RB) V02 tmp1         
N008 (  3,  2) [000000] ------------ this in rcx  ├──▌  LCL_VAR   ref    V00 arg0         
N009 (  2, 10) [000010] H----------- arg1 in r11  ├──▌  CNS_INT(h) long   0x7ffa31320008 ftn REG r11
N010 (  1,  1) [000001] ------------ arg3 in r8   ├──▌  CNS_INT   int    1
N011 (  1,  1) [000002] ------------ arg4 in r9   └──▌  CNS_INT   int    2

I had to increase the margin by a bit to fit this new info and I did not notice that this string also needed to change.

cc @dotnet/jit-contrib

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall BruceForstall merged commit aacf2b6 into dotnet:main Apr 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants