Infra fixes for bugs uncovered by testing of the JIT/Methodical merged tests #67393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich files to skip running the Mono AOT compiler on (some tests fail at AOT time, so we need this to work around that limitation)
…ion list creation
…es issues with Helix test uploading.
… we correctly report failures and don't report a test harness failure.
Pre-emptively mark another test as RequiresProcessIsolation as I stumbled upon it while fixing this
Due to Pri0 / Pri1 test grouping we may end up building the wrapper in a different group than its components. Make sure that we populate all native components of merged wrapper dependencies before we copy them over to the merged wrapper output folder. Thanks Tomas
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis is a series of changes made by Jeremy and myself based on our observations from lab testing Thanks Tomas
|
jkoritzinsky
requested changes
Mar 31, 2022
ghost
added
the
needs-author-action
ghost
removed
the
needs-author-action
jkoritzinsky
approved these changes
Mar 31, 2022
jkoritzinsky
reviewed
Apr 1, 2022
src/tests/Loader/classloader/MethodImpl/CovariantReturns/UnitTest/UnitTestMultiModule.ilproj
Outdated
Show resolved
Hide resolved
…est/UnitTestMultiModule.ilproj
jkoritzinsky
reviewed
Apr 1, 2022
src/tests/Loader/classloader/generics/Variance/IL/Unbox002.csproj
Outdated
Show resolved
Hide resolved
src/tests/Loader/classloader/generics/Variance/IL/Unbox003.csproj
Outdated
Show resolved
Hide resolved
src/tests/Loader/classloader/generics/Variance/IL/vsw543506.csproj
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of changes made by Jeremy and myself based on our observations from lab testing
of the JIT/Methodical switchover to use merged test wrappers. They deal with various previously
unseen special cases like passing payloads for out-of-process tests to Helix, proper propagation
of test exclusion list (issues.targets) to the generated merged wrapper and multiple fixes for Mono.
Thanks
Tomas