Skip to content

Conversation

NN---
Copy link
Contributor

@NN--- NN--- commented Jan 2, 2022

Attempt to address #37310

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 2, 2022
@ghost
Copy link

ghost commented Jan 2, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@NN--- NN--- closed this Jan 2, 2022
@NN--- NN--- reopened this Jan 2, 2022
@NN--- NN--- requested a review from jkotas January 3, 2022 06:41
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would be nice to convert the remaining SAL v1 annotations to SAL v2 annotations for consistency. I have opened #63307 to track it.

@jkotas jkotas merged commit 9472bfe into dotnet:main Jan 3, 2022
@jkotas
Copy link
Member

jkotas commented Jan 3, 2022

@NN--- Thank you!

@NN--- NN--- deleted the sal2 branch January 6, 2022 17:54
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants