fix issue where HTTP2 connection could be scavenged but not disposed #62225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
karelz
approved these changes
Dec 1, 2021
ManickaP
approved these changes
Dec 1, 2021
stephentoub
approved these changes
Dec 1, 2021
Member
|
Looks like this was introduced in July for .NET 6. We should probably service it. |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1526252602 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scavenging connections, if we end up scavenging at least one HTTP/1.1 connection and at least one HTTP2 connection for the same connection pool (i.e. origin server), the first HTTP2 connection will be removed from the connection list but not disposed, leading to a connection leak.
Having both HTTP/1.1 and HTTP2 connections to the same server is not common, but if this happens the impact is pretty bad.