Skip to content

Ensure MaxBy/MinBy return first element if all keys are null. #61364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Ensure MaxBy/MinBy return first element if all keys are null. #61364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/libraries/System.Linq/src/System/Linq/Max.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,15 +583,22 @@ public static decimal Max(this IEnumerable<decimal> source)

if (default(TKey) is null)
{
while (key == null)
if (key == null)
{
if (!e.MoveNext())
TSource firstValue = value;

do
{
return value;
}
if (!e.MoveNext())
{
// All keys are null, surface the first element.
return firstValue;
}

value = e.Current;
key = keySelector(value);
value = e.Current;
key = keySelector(value);
}
while (key == null);
}

while (e.MoveNext())
Expand Down
19 changes: 13 additions & 6 deletions src/libraries/System.Linq/src/System/Linq/Min.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,15 +541,22 @@ public static decimal Min(this IEnumerable<decimal> source)

if (default(TKey) is null)
{
while (key == null)
if (key == null)
{
if (!e.MoveNext())
TSource firstValue = value;

do
{
return value;
}
if (!e.MoveNext())
{
// All keys are null, surface the first element.
return firstValue;
}

value = e.Current;
key = keySelector(value);
value = e.Current;
key = keySelector(value);
}
while (key == null);
}

while (e.MoveNext())
Expand Down
24 changes: 12 additions & 12 deletions src/libraries/System.Linq/tests/MaxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,27 +890,27 @@ public static void MaxBy_Generic_EmptyReferenceSource_ReturnsNull()
}

[Fact]
public static void MaxBy_Generic_StructSourceAllKeysAreNull_ReturnsLastElement()
public static void MaxBy_Generic_StructSourceAllKeysAreNull_ReturnsFirstElement()
{
Assert.Equal(4, Enumerable.Range(0, 5).MaxBy(x => default(string)));
Assert.Equal(4, Enumerable.Range(0, 5).MaxBy(x => default(string), comparer: null));
Assert.Equal(4, Enumerable.Range(0, 5).MaxBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
Assert.Equal(0, Enumerable.Range(0, 5).MaxBy(x => default(string)));
Assert.Equal(0, Enumerable.Range(0, 5).MaxBy(x => default(string), comparer: null));
Assert.Equal(0, Enumerable.Range(0, 5).MaxBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
}

[Fact]
public static void MaxBy_Generic_NullableSourceAllKeysAreNull_ReturnsLastElement()
public static void MaxBy_Generic_NullableSourceAllKeysAreNull_ReturnsFirstElement()
{
Assert.Equal(4, Enumerable.Range(0, 5).Cast<int?>().MaxBy(x => default(int?)));
Assert.Equal(4, Enumerable.Range(0, 5).Cast<int?>().MaxBy(x => default(int?), comparer: null));
Assert.Equal(4, Enumerable.Range(0, 5).Cast<int?>().MaxBy(x => default(int?), Comparer<int?>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
Assert.Equal(0, Enumerable.Range(0, 5).Cast<int?>().MaxBy(x => default(int?)));
Assert.Equal(0, Enumerable.Range(0, 5).Cast<int?>().MaxBy(x => default(int?), comparer: null));
Assert.Equal(0, Enumerable.Range(0, 5).Cast<int?>().MaxBy(x => default(int?), Comparer<int?>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
}

[Fact]
public static void MaxBy_Generic_ReferenceSourceAllKeysAreNull_ReturnsLastElement()
public static void MaxBy_Generic_ReferenceSourceAllKeysAreNull_ReturnsFirstElement()
{
Assert.Equal("4", Enumerable.Range(0, 5).Select(x => x.ToString()).MaxBy(x => default(string)));
Assert.Equal("4", Enumerable.Range(0, 5).Select(x => x.ToString()).MaxBy(x => default(string), comparer: null));
Assert.Equal("4", Enumerable.Range(0, 5).Select(x => x.ToString()).MaxBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
Assert.Equal("0", Enumerable.Range(0, 5).Select(x => x.ToString()).MaxBy(x => default(string)));
Assert.Equal("0", Enumerable.Range(0, 5).Select(x => x.ToString()).MaxBy(x => default(string), comparer: null));
Assert.Equal("0", Enumerable.Range(0, 5).Select(x => x.ToString()).MaxBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
}

[Theory]
Expand Down
24 changes: 12 additions & 12 deletions src/libraries/System.Linq/tests/MinTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,27 +868,27 @@ public static void MinBy_Generic_EmptyReferenceSource_ReturnsNull()
}

[Fact]
public static void MinBy_Generic_StructSourceAllKeysAreNull_ReturnsLastElement()
public static void MinBy_Generic_StructSourceAllKeysAreNull_ReturnsFirstElement()
{
Assert.Equal(4, Enumerable.Range(0, 5).MinBy(x => default(string)));
Assert.Equal(4, Enumerable.Range(0, 5).MinBy(x => default(string), comparer: null));
Assert.Equal(4, Enumerable.Range(0, 5).MinBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
Assert.Equal(0, Enumerable.Range(0, 5).MinBy(x => default(string)));
Assert.Equal(0, Enumerable.Range(0, 5).MinBy(x => default(string), comparer: null));
Assert.Equal(0, Enumerable.Range(0, 5).MinBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
}

[Fact]
public static void MinBy_Generic_NullableSourceAllKeysAreNull_ReturnsLastElement()
public static void MinBy_Generic_NullableSourceAllKeysAreNull_ReturnsFirstElement()
{
Assert.Equal(4, Enumerable.Range(0, 5).Cast<int?>().MinBy(x => default(int?)));
Assert.Equal(4, Enumerable.Range(0, 5).Cast<int?>().MinBy(x => default(int?), comparer: null));
Assert.Equal(4, Enumerable.Range(0, 5).Cast<int?>().MinBy(x => default(int?), Comparer<int?>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
Assert.Equal(0, Enumerable.Range(0, 5).Cast<int?>().MinBy(x => default(int?)));
Assert.Equal(0, Enumerable.Range(0, 5).Cast<int?>().MinBy(x => default(int?), comparer: null));
Assert.Equal(0, Enumerable.Range(0, 5).Cast<int?>().MinBy(x => default(int?), Comparer<int?>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
}

[Fact]
public static void MinBy_Generic_ReferenceSourceAllKeysAreNull_ReturnsLastElement()
public static void MinBy_Generic_ReferenceSourceAllKeysAreNull_ReturnsFirstElement()
{
Assert.Equal("4", Enumerable.Range(0, 5).Select(x => x.ToString()).MinBy(x => default(string)));
Assert.Equal("4", Enumerable.Range(0, 5).Select(x => x.ToString()).MinBy(x => default(string), comparer: null));
Assert.Equal("4", Enumerable.Range(0, 5).Select(x => x.ToString()).MinBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
Assert.Equal("0", Enumerable.Range(0, 5).Select(x => x.ToString()).MinBy(x => default(string)));
Assert.Equal("0", Enumerable.Range(0, 5).Select(x => x.ToString()).MinBy(x => default(string), comparer: null));
Assert.Equal("0", Enumerable.Range(0, 5).Select(x => x.ToString()).MinBy(x => default(string), Comparer<string>.Create((_, _) => throw new InvalidOperationException("comparer should not be called."))));
}

[Theory]
Expand Down