Remove SkipOn NetFramework attributes in System.Reflection.Emit tests #60103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are not run on netfx, so these attributes are just clutter.
|
Tagging subscribers to this area: @buyaa-n Issue DetailsThese tests are not run on netfx, so these attributes are just clutter.
|
danmoseley
approved these changes
Oct 6, 2021
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
I wonder whether it is worth a grep for SkipOnTargetFramework.*TargetFrameworkMonikers.NetFramework or something in code of our other tests that don't run on .NET Framework.
Member
Member
Author
I can take a look when I get time. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are not run on netfx, so these attributes are just clutter.