Skip to content

Remove PlainPointer, RelativePointer and RelativeFixupPointer #57707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 24, 2021
Merged

Remove PlainPointer, RelativePointer and RelativeFixupPointer #57707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b223446
First pass at cleaning up PlainPointer and RelativePointer
davidwrighton Aug 19, 2021
79c4257
Remove all use of RelativeFixupPointer
davidwrighton Aug 19, 2021
5d42264
Remove all use of FixupPointer
davidwrighton Aug 19, 2021
1bc6dd0
Remove RelativePointer
davidwrighton Aug 19, 2021
b9b86c6
Fix issues where dereferences were wrong/missing
davidwrighton Aug 20, 2021
5556eb6
Fix IsNull checks
davidwrighton Aug 20, 2021
2a17292
Merge branch 'main' of github.com:dotnet/runtime into RemoveFancyPoin…
davidwrighton Aug 20, 2021
a00f2a2
Merge branch 'main' of github.com:dotnet/runtime into RemoveFancyPoin…
davidwrighton Aug 23, 2021
31fb5d3
Update src/coreclr/vm/jitinterface.cpp
davidwrighton Aug 24, 2021
a4e79bb
Merge branch 'main' into RemoveFancyPointers
davidwrighton Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/debug/daccess/request.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ HRESULT ClrDataAccess::GetMethodDescData(
methodDescData->bHasNativeCode = FALSE;
methodDescData->NativeCodeAddr = (CLRDATA_ADDRESS)-1;
}
methodDescData->AddressOfNativeCodeSlot = pMD->HasNativeCodeSlot() ? TO_CDADDR(pMD->GetAddrOfNativeCodeSlot()) : NULL;
methodDescData->AddressOfNativeCodeSlot = pMD->HasNativeCodeSlot() ? TO_CDADDR(dac_cast<TADDR>(pMD->GetAddrOfNativeCodeSlot())) : NULL;
methodDescData->MDToken = pMD->GetMemberDef();
methodDescData->MethodDescPtr = methodDesc;
methodDescData->MethodTablePtr = HOST_CDADDR(pMD->GetMethodTable());
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/inc/corcompile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
#include <daccess.h>
#include <corbbtprof.h>
#include <clrtypes.h>
#include <fixuppointer.h>

typedef DPTR(struct CORCOMPILE_EXCEPTION_LOOKUP_TABLE)
PTR_CORCOMPILE_EXCEPTION_LOOKUP_TABLE;
Expand Down
Loading