[wasm][debugger] Fixing async locals in nested ContinueWith blocks #56911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsAdding test to close #41984
|
lewing
approved these changes
Aug 5, 2021
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
radical
requested changes
Aug 6, 2021
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Looking good! Just some feedback
src/mono/wasm/debugger/tests/debugger-test/debugger-async-test.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ankit Jain <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
thaystg
changed the title
radical
reviewed
Aug 6, 2021
radical
reviewed
Aug 6, 2021
radical
reviewed
Aug 6, 2021
| var match = regex.Match(fieldName); | ||
| if (match.Success) | ||
| asyncLocal["name"] = match.Groups[1].Value; | ||
| asyncLocalsFull.Add(asyncLocal); |
Member
There was a problem hiding this comment.
Would this still be valid without a name? If not, then we shouldn't add it to asyncLocalsFull, and just skip it.
radical
reviewed
Aug 6, 2021
| retDebuggerCmdReader = await SendDebuggerAgentCommand<CmdFrame>(sessionId, CmdFrame.GetThis, commandParams, token); | ||
| retDebuggerCmdReader.ReadByte(); //ignore type | ||
| var objectId = retDebuggerCmdReader.ReadInt32(); | ||
| var asyncLocals = await GetObjectValues(sessionId, objectId, true, false, false, false, token); |
Member
There was a problem hiding this comment.
Just curious, what does this return? reference to the generated class?
radical
reviewed
Aug 6, 2021
radical
reviewed
Aug 6, 2021
radical
reviewed
Aug 6, 2021
radical
reviewed
Aug 6, 2021
lewing
approved these changes
Aug 6, 2021
Member
|
The changes did not impact the lanes that had failed. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContinueWithblock #41984