Skip to content

Fix the outer loop compilation errors #56889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2021
Merged

Fix the outer loop compilation errors #56889

merged 1 commit into from
Aug 5, 2021

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Aug 5, 2021

#56757 broke the outerloop Pri1 test build. We are getting following build errors:

/__w/1/s/src/coreclr/tools/Common/TypeSystem/Common/ExplicitLayoutValidator.cs(56,52): error CS0573: 'ExplicitLayoutValidator': cannot have instance property or field initializers in structs [/__w/1/s/src/tests/ilverify/ILVerification.Tests.csproj]
##[error]src/coreclr/tools/Common/TypeSystem/Common/ExplicitLayoutValidator.cs(56,52): error CS0573: 'ExplicitLayoutValidator': cannot have instance property or field initializers in structs

The fix just moves the initialization into the constructor. I hope it preserves what we want to achieve.

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Aug 5, 2021 •
edited
Loading

@davidwrighton @trylek

@kunalspathak kunalspathak added the blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs label Aug 5, 2021
@jakobbotsch jakobbotsch mentioned this pull request Aug 5, 2021
Closed
@jakobbotsch jakobbotsch merged commit e4d4f98 into dotnet:main Aug 5, 2021
@jakobbotsch jakobbotsch mentioned this pull request Aug 5, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sandreenko sandreenko sandreenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-crossgen2-coreclr blocking-outerloop Blocking the 'runtime-coreclr outerloop' and 'runtime-libraries-coreclr outerloop' runs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kunalspathak @sandreenko @jakobbotsch