Skip to content

Add AggressiveInlining to Double.CompareTo() and Single.CompareTo() #56501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Add AggressiveInlining to Double.CompareTo() and Single.CompareTo() #56501

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb0f8cb
Add AggressiveInlining to Double.CompareTo() and Single.CompareTo()
rickbrew Jul 28, 2021
f7a10f0
Use split inlining
rickbrew Aug 17, 2021
08f46fb
Revert split inlining
rickbrew Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Private.CoreLib/src/System/Double.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ public int CompareTo(object? value)
throw new ArgumentException(SR.Arg_MustBeDouble);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public int CompareTo(double value)
{
if (m_value < value) return -1;
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Private.CoreLib/src/System/Single.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ public int CompareTo(object? value)
throw new ArgumentException(SR.Arg_MustBeSingle);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public int CompareTo(float value)
{
if (m_value < value) return -1;
Expand Down