Skip to content

Enable Float32, fix linears optimization, and rework LOCALLOC #56111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2021
Merged

Enable Float32, fix linears optimization, and rework LOCALLOC #56111

merged 1 commit into from
Jul 22, 2021

Conversation

@nealef
Copy link
Contributor

@nealef nealef commented Jul 21, 2021

  • Enable full float32 support
    • Add instructions for FP operations: abs[f]/ceil[f]/floor[f]/round[f]/sqrt[f]/trunc[f]
    • Enable these instructions in mono_arch_emit_inst_for_method()
    • Handle return of float32 results
    • Correct rounding mode for OP_LCONV_TO_R_UN processing
  • Enable MONO_OPT_LINEAR optimizations
    • Correct prolog processing of structure returned variable
  • Rework OP_LOCALLOC for cases where alloc size > 4k
  • Add OP_POPCNTxx support
  • Minor typo (missing tab)

@nealef
- Enable full float32 support
d77e181 
-- Add instructions for FP operations: abs[f]/ceil[f]/floor[f]/round[f]/sqrt[f]/trunc[f]
-- Enable these instructions in mono_arch_emit_inst_for_method()
-- Handle return of float32 results
-- Correct rounding mode for OP_LCONV_TO_R_UN processing
- Enable MONO_OPT_LINEAR optimizations
-- Correct prolog processing of structure returned variable
- Rework OP_LOCALLOC for cases where alloc size > 4k
- Add OP_POPCNTxx support
- Minor typo (missing tab)
@akoeplinger akoeplinger merged commit b937677 into dotnet:main Jul 22, 2021
@nealef nealef deleted the s390-fixes branch July 23, 2021 00:57
@uweigand uweigand mentioned this pull request Jul 28, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@imhameed imhameed Awaiting requested review from imhameed

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

1 more reviewer

@vargaz vargaz vargaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Codegen-JIT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nealef @vargaz @akoeplinger