Skip to content

HTTP/3: Fix variable length encoding #51486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2021
Merged

HTTP/3: Fix variable length encoding #51486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...raries/Common/src/System/Net/Http/aspnetcore/Http3/Helpers/VariableLengthIntegerHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ internal static class VariableLengthIntegerHelper

// public for internal use in aspnetcore
public const uint OneByteLimit = (1U << 6) - 1;
public const uint TwoByteLimit = (1U << 16) - 1;
public const uint TwoByteLimit = (1U << 14) - 1;
public const uint FourByteLimit = (1U << 30) - 1;
public const long EightByteLimit = (1L << 62) - 1;

Expand Down
4 changes: 4 additions & 0 deletions src/libraries/Common/src/System/Net/Http/aspnetcore/Http3/QPack/HeaderField.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ namespace System.Net.Http.QPack
{
internal readonly struct HeaderField
{
// https://quicwg.org/base-drafts/draft-ietf-quic-http.html#section-4.1.1.3-1
// public for internal use in aspnetcore
public const int RfcOverhead = 32;

public HeaderField(byte[] name, byte[] value)
{
Name = name;
Expand Down