Allow region_allocator to allocate from the right #50973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cshung merged 5 commits into dotnet:main from cshung:public/move-poh-right

Apr 21, 2021

Contributor

cshung commented Apr 8, 2021 •

edited

Loading

Remove the parts where I allocate the POH regions from the right-hand side, the remaining parts of the system is not ready for that yet.

cshung added the area-GC-coreclr label

ghost commented Apr 8, 2021

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	cshung
Assignees:	-
Labels:	`area-GC-coreclr`
Milestone:	-

cshung marked this pull request as draft

April 8, 2021 21:48

cshung changed the title ~~Move POH regions to the higher VA side~~ Allow region_allocator to allocate from the right

cshung commented

View reviewed changes

Contributor Author

cshung left a comment

Just noted a couple of things I will change.

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved

src/coreclr/gc/gcpriv.h Outdated Show resolved Hide resolved

cshung force-pushed the public/move-poh-right branch from b7281c8 to 3ded428 Compare

April 15, 2021 00:39

cshung marked this pull request as ready for review

April 16, 2021 16:05

Maoni0 reviewed

View reviewed changes

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved

Maoni0 reviewed

View reviewed changes

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved

Maoni0 reviewed

View reviewed changes

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved

Maoni0 reviewed

View reviewed changes

src/coreclr/gc/gcpriv.h Outdated Show resolved Hide resolved

Maoni0 reviewed

View reviewed changes

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved

Maoni0 reviewed

View reviewed changes

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved

Maoni0 reviewed

View reviewed changes

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved

Maoni0 approved these changes

View reviewed changes

Member

Maoni0 left a comment

other than changing the last places to use the enum, this LGTM

cshung added 5 commits

April 21, 2021 09:02


          Move POH regions to the higher VA side

ea58706


          Allow region_allocator to allocate from the right

94605ad


          Code review feedback

682067c


          More code review feedback

34a227a


          Last change

69804f6

cshung force-pushed the public/move-poh-right branch from 6d04b82 to 69804f6 Compare

April 21, 2021 16:03

runfoapp bot mentioned this pull request

System.Tests.GCTests.LatencyRoundtrips failing in CI #51635

Closed

cshung merged commit 2257dad into dotnet:main

cshung deleted the public/move-poh-right branch

April 21, 2021 20:32

karelz added this to the 6.0.0 milestone

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-GC-coreclr