Skip to content

Annotate APIs in System.Private.Xml #49682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 5, 2021
Merged

Annotate APIs in System.Private.Xml #49682

merged 12 commits into from
Apr 5, 2021

Conversation

@agocke
Copy link
Member

@agocke agocke commented Mar 16, 2021

Mostly adds RequiresUnreferencedCode, and propagates the results
outward.

@ghost
Copy link

ghost commented Mar 16, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 16, 2021

Tagging subscribers to this area: @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

Mostly adds RequiresUnreferencedCode, and propagates the results
outward.

Author: agocke
Assignees: -
Labels:

area-System.Xml, new-api-needs-documentation
Milestone: -

@runfoapp runfoapp bot mentioned this pull request Mar 16, 2021
Open
@eerhardt eerhardt added the linkable-framework Issues associated with delivering a linker friendly framework label Mar 16, 2021
@ghost
Copy link

ghost commented Mar 16, 2021

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer
See info in area-owners.md if you want to be subscribed.

Issue Details

Mostly adds RequiresUnreferencedCode, and propagates the results
outward.

Author: agocke
Assignees: -
Labels:

area-System.Xml, linkable-framework, new-api-needs-documentation
Milestone: -

@eerhardt
Copy link
Member

eerhardt commented Mar 16, 2021

Can you remove any suppressions from https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.Xml/src/ILLink/ILLink.Suppressions.xml that are now marked with RUC?

eerhardt
eerhardt reviewed Mar 16, 2021
View reviewed changes
@vitek-karas
Copy link
Member

vitek-karas commented Mar 16, 2021

@LakshanF FYI

@agocke
Copy link
Member Author

agocke commented Mar 17, 2021

@eerhardt Any way to automatically generate ILLink suppression files? Or is it totally manual?

@eerhardt
Copy link
Member

eerhardt commented Mar 17, 2021

Any way to automatically generate ILLink suppression files? Or is it totally manual?

See https://github.com/dotnet/runtime/pull/44264/files, which is unmerged. You can pass --generate-warning-suppressions xml to the linker and it will generate the .xml file under the artifacts\bin\ILLinkTrimAssembly folder.

eerhardt
eerhardt reviewed Mar 17, 2021
View reviewed changes
eerhardt
eerhardt reviewed Mar 17, 2021
View reviewed changes
joperezr
joperezr reviewed Mar 19, 2021
View reviewed changes
@joperezr joperezr force-pushed the xmlserializer-warnings branch from f9fda0a to b0d278c Compare March 27, 2021 18:03
@eerhardt eerhardt mentioned this pull request Mar 30, 2021
Merged
eerhardt
eerhardt approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment to fix the Writer like we did for the Reader. Fix that and then we should merge this in.

@agocke
Copy link
Member Author

agocke commented Apr 5, 2021

Thanks everyone!

@agocke agocke merged commit b3e3db9 into dotnet:main Apr 5, 2021
@agocke agocke deleted the xmlserializer-warnings branch April 5, 2021 18:59
thaystg added a commit to thaystg/runtime that referenced this pull request Apr 6, 2021
@thaystg
Merge remote-tracking branch 'upstream/main' into thays_implement_dbg…
21e5d46 
…shim_mono

# By Aaron Robinson (10) and others
# Via GitHub
* upstream/main: (108 commits)
  [mbr] Add Apple sample (dotnet#50740)
  make EstablishProxyTunnelAsync throw on failure status code from proxy (dotnet#50763)
  Improve RGB Min Max evaluation performance by using 2 or 3 comparison… (dotnet#50622)
  [mono] More domain cleanups (dotnet#50479)
  Fix Crossgen2 of PlatformDefaultMemberFunction methods and calls. (dotnet#50754)
  Disable EventSource generator in design-time builds (dotnet#50741)
  Fix X509 test failures on Android (dotnet#50301)
  Do not confuse fgDispBasicBlocks in fgMorphBlocks (dotnet#50703)
  Enforce 64KB event payload size limit on EventPipe  (dotnet#50600)
  Reorganize CoreCLR native build to reduce CMake reconfigures when the build system is untouched (dotnet#49906)
  [mbr] Turn on hot reload for iOS, tvOS and MacCatalyst (dotnet#50458)
  improve connection scavenge logic by doing zero-byte read (dotnet#50545)
  Resolve call mdtokens when making tier 1 inline observations (dotnet#50675)
  Annotate APIs in System.Private.Xml (dotnet#49682)
  Support compiling against OpenSSL 3 headers
  Change Configuration.Json to use a regular Dictionary. (dotnet#50611)
  Remove unused BigNumFromBinary P/Invoke (dotnet#50670)
  Make Ninja the default CMake generator on Windows for the repo (dotnet#49715)
  [AppleAppBuilder] Entitlements to run tests on catalyst using the JIT (dotnet#50637)
  [mono] Fix delegate invokes to dynamic methods in mixed mode. (dotnet#50547)
  ...

# Conflicts:
#	src/mono/dlls/mscordbi/CMakeLists.txt
@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@vitek-karas vitek-karas vitek-karas left review comments

@MichalStrehovsky MichalStrehovsky MichalStrehovsky left review comments

@joperezr joperezr joperezr left review comments

@eerhardt eerhardt eerhardt approved these changes

Assignees

No one assigned

Labels

area-System.Xml linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@agocke @eerhardt @vitek-karas @ViktorHofer @MichalStrehovsky @joperezr @karelz