Bring up Android and Browser cross-compilers on Windows #47589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…K in the NewSFX subset.
…nuget packaging projects.
… from the runtime.
pranavkm
reviewed
Feb 1, 2021
Co-authored-by: Pranav K <[email protected]>
Apparently, CMake on Windows doesn't codify INCLUDE/LIB into the build system from configure, just CC/CCX, so if you run build without initializing the compiler again, you get failures from missing .h files
This was referenced Feb 9, 2021
Member
|
Failure looks like #48075 |
steveisok
approved these changes
Feb 10, 2021
Member
|
Looks good. Way to swim through the pathing issues 👍 |
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Feb 12, 2021
Ninja isn't installed on the CentOS Linux Docker image we're using. This got broken by dotnet#47589.
akoeplinger
added a commit
that referenced
this pull request
Feb 12, 2021
* Only use ninja on Windows for Mono cross AOT compiler build Ninja isn't installed on the CentOS Linux Docker image we're using. This got broken by #47589. * Fix Windows leg
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus far, only Android x64 cross compiler - we have been very lax with separating our use of HOST_WINDOWS vs TARGET_WINDOWS, and attempting to cross compile for other architectures fails horribly. This should get us at least partial progress towards the goal of platform parity on Windows with Linux.