Socket.Tests: remove TestSettings.UDPRedundancy #44202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
Contributor
Author
|
/cc @wfurt |
geoffkizer
approved these changes
Nov 3, 2020
stephentoub
approved these changes
Nov 3, 2020
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
LGTM if @wfurt is happy with it (he's been looking a lot at test failures).
Member
|
I think this may be ok - I certainly like the simplification. We can watch the results and react if we see new failures. |
Member
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Nov 3, 2020
Contributor
Author
|
The The |
Contributor
Author
Contributor
Author
|
/azp run runtime-libraries-coreclr outerloop |
Contributor
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/corefx#15697 changed this value to 1, and no-one touched it since then.
As the comment in that PR points out, the root cause of the UDP test failures wasn't packet loss, but IPv4 / IPv6 port collision on Unix in dual-mode cases.
The value and the for loops are complicating Socket test code unnecessarily, simplification seems reasonable.
/cc @geoffkizer @stephentoub