Skip to content

Conversation

@vcsjones
Copy link
Member

Since CreateHMAC accepts a span now, use it where applicable.

PR is much easier to review when ignoring white space differences.

@ghost
Copy link

ghost commented Oct 16, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

@vcsjones
Copy link
Member Author

@bartonjs I totally spaced on the downlevel targets. I put some #ifs there to get things moving along, but, if you think the impact on code readability isn't worth it, feel free to close the PR.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@bartonjs bartonjs merged commit ebe2a70 into dotnet:master Oct 19, 2020
@vcsjones vcsjones deleted the createhmac-span branch October 19, 2020 17:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants