-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Enable using the Ninja generator instead of Visual Studio on Windows builds. #41897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
cad3f29
Move DacTableGen out of the CMake build and into tools-local.
jkoritzinsky e921ecc
Merge branch 'master' of https://github.com/dotnet/runtime into dacta…
jkoritzinsky a69c346
Attempt: usenmakefiles means ninja.
jkoritzinsky d1b12b5
Make changes to Windows build to support non-VS generators like ninja.
jkoritzinsky df589ef
Use CMake 3.16 PCHs.
jkoritzinsky 0524739
Remove explicit process count.
jkoritzinsky e99246f
Build and run DacTableGen via the .NET CLI we pull down for the build…
jkoritzinsky 03140d8
Update configurecompiler.cmake to specify language (needed for Ninja).
jkoritzinsky 9bdf0f1
Merge branch 'ninja-windows' of github.com:jkoritzinsky/runtime into …
jkoritzinsky 417b07a
Get Ninja build working again.
jkoritzinsky db7454a
Merge branch 'master' of https://github.com/dotnet/runtime into ninja…
jkoritzinsky b70eeca
Pass configuration to cmake configure step for Ninja build.
jkoritzinsky 36cc91e
Rename flag
jkoritzinsky fe484c9
Fix configure step for cross-arch native build
jkoritzinsky cba81df
Support building via Ninja for coreclr via an MSBuild property
jkoritzinsky c20b356
Implement support for opening the CoreCLR solution in VS via the -vs …
jkoritzinsky 86f5f90
Fix setting generator to Ninja.
jkoritzinsky a2478cc
Merge libraries gen-buildsys-win.bat with runtime gen-buildsys.cmd to…
jkoritzinsky ca84dd2
Enable building libraries native build with ninja.
jkoritzinsky 3b17211
Centralize setting CMAKE_SYSTEM_VERSION for windows builds.
jkoritzinsky 8422b09
Update host build to use shared gen-buildsys.cmd
jkoritzinsky 885974e
Fix multi-config generator detection.
jkoritzinsky a8feb74
Exit with success when we build successfully.
jkoritzinsky e7b9280
Enable and fix up Ninja build for hosts.
jkoritzinsky 6bcaec4
Only link delayimp.lib on Windows
jkoritzinsky cb1f6a1
Remove "overriding /W3 with /W1" warning in Ninja build of hosts by t…
jkoritzinsky 03c4cc9
Reduce command line override warnings by adopting the MSVC_RUNTIME_LI…
jkoritzinsky 0378122
Use the delayed expansion syntax to correctly pass in the config to c…
jkoritzinsky 195fa3e
Move all usages of MSVC runtime library selection to the CMake abstra…
jkoritzinsky 7c7c168
Condition the rest of the compiler options correctly so they don't sh…
jkoritzinsky 5dc02c0
Correctly build DIALib and DacTableGen as AnyCPU
jkoritzinsky 86019b9
Fix WRITE_BARRIER_CHECK define
jkoritzinsky 823cef9
Fix passing arch for MSBuild build.
jkoritzinsky 3e60c98
Configure ASM compiler command line format in configurecompiler.cmake…
jkoritzinsky 4d81fe8
Cleanup after fixing ARM/ARM64 support.
jkoritzinsky 8286fba
Rename variable
jkoritzinsky 0d9205a
Merge branch 'master' into ninja-windows
jkoritzinsky 82f0491
Condition PCH's for C++-only as needed to fix using them on non-Windo…
jkoritzinsky 6541aeb
Fix CoreCLR native test build on windows to point to new gen-buildsys…
jkoritzinsky ca101e9
Add missing compilation options in Ninja build that are implicitly de…
jkoritzinsky 78fd252
Merge branch 'master' into ninja-windows
jkoritzinsky 18acb6f
Disable analyzers for DacTableGen. Remove /MAP linker flag (that's fo…
jkoritzinsky d38ae03
Upgrade to CMake 3.16.4
jkoritzinsky 5051f71
Merge branch 'master' of github.com:dotnet/runtime into ninja-windows
jkoritzinsky 43e8a7b
Don't warn on unused variables in CMake (these usually vary on platfo…
jkoritzinsky a34284e
Manually compile ARM and ARM64 asm files when using the VS generator …
jkoritzinsky ccd66f5
Merge branch 'master' of github.com:dotnet/runtime into ninja-windows
jkoritzinsky 992817d
Enable CMake policy in test build to use CMAKE_MSVC_RUNTIME_LIBRARY v…
jkoritzinsky 7db1ecb
Merge branch 'ninja-windows' of github.com:jkoritzinsky/runtime; bran…
jkoritzinsky aa79e4f
Update initially disabled warnings in host.
jkoritzinsky 327b002
Add -ninja arg to root scripts to enable using Ninja.
jkoritzinsky bc701d1
Enable using Ninja in CoreCLR CI.
jkoritzinsky d95091e
Merge branch 'master' of github.com:dotnet/runtime into ninja-windows
jkoritzinsky 334293c
Try to fix passing the -ninja arg in yaml.
jkoritzinsky c1b3676
Add ninja to the Windows invocation
jkoritzinsky 2945f4d
Merge branch 'master' of github.com:dotnet/runtime into ninja-windows
jkoritzinsky cfc26f5
Fix 2-phase cross targeting to do one phase at a time and initialize …
jkoritzinsky 343690e
Restore old /Ox optimization setting for Release.
jkoritzinsky 9af32b3
Fix typos, don't pass exception flags to C files.
jkoritzinsky 61e4c81
Remove unneeded pragma.
jkoritzinsky a437115
Merge branch 'master' of github.com:dotnet/runtime into ninja-windows
jkoritzinsky 83939c6
Fix .pgd file installation.
jkoritzinsky f95c8f6
Add mention of the `-ninja` flag in the Building CoreCLR documentation.
jkoritzinsky ff80bab
Mention installation locations for Ninja and warn while building if C…
jkoritzinsky 4db3105
Update docs/workflow/requirements/windows-requirements.md
jkoritzinsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.